Restore recipe parameters functionality by zanesq · Pull Request #3530 · block/goose

zanesq · 2025-07-20T01:00:44Z

Recipe parameters stopped working after the new ui launch.

This adds them back and fixes some issues I noticed along the way:

Navigating away from an active recipe in chat and back to chat now keeps your chat showing rather than trying to reload the recipe from scratch.
Clicking on working directory or other buttons in the chat area no longer auto submits the chat form.

Bonus:

Added a few more parameter form fields while I was in there select, boolean and number.
Added the remaining recipe fields in the preview modal with a deeplink for easy sharing.

zanesq · 2025-07-20T01:03:38Z

ui/desktop/openapi.json

            "format": "double",
            "description": "Cost per token for output (optional)",
            "nullable": true
+          },


upstream changes can ignore

zanesq · 2025-07-20T01:03:49Z

ui/desktop/src/api/types.gen.ts

     * Cost per token for output (optional)
     */
    output_token_cost?: number | null;
+    /**


upstream changes can ignore

should we maybe have something in CI that checks whether regenerating the openapi.json is a no-op?

Not sure if ci can help this other than maybe flagging when someone didn't manually generate it? It should be manually generated whenever someone makes a related change. I run the full npm run start locally which generates the types so occasionally I run into this issue where someone didn't generate the types upstream.

yeah, I meant we could run the typegen in ci and compare if it changes anything and if it does, tell the user they forgot to run it but did make a change

Ah gotcha, good idea! Will follow up with that 👍

zanesq · 2025-07-20T01:05:28Z

ui/desktop/src/components/ChatInput.tsx

-            )}
-          </div>
+      {/* Input row with inline action buttons wrapped in form */}
+      <form onSubmit={onFormSubmit} className="relative flex items-end">


form now wraps only what it should, the input and the submit/action buttons, before it was wrapping all the actions under the chat input causing the chat form to submit from descendant buttons in launched modals or the working directory click

zanesq · 2025-07-20T01:06:36Z

ui/desktop/src/components/BaseChat.tsx

                            {error.message || 'Honk! Goose experienced an error while responding'}
                          </div>

-                          {/* Expandable Error Details */}


Removed this expandable error details area as it wasn't providing any other useful context than what is displayed on the screen.

DOsinga

Thanks for jumping on this. I added some maybe too detailed review for a quick fix. In general my question is also, what can we do to test this automatically? these flows are hard to follow I find and seem like having bugs in them would be easy

DOsinga · 2025-07-20T08:54:32Z

ui/desktop/src/api/types.gen.ts

     * Cost per token for output (optional)
     */
    output_token_cost?: number | null;
+    /**


should we maybe have something in CI that checks whether regenerating the openapi.json is a no-op?

DOsinga · 2025-07-20T09:05:34Z

ui/desktop/src/components/BaseChat.tsx

-      if (recipeConfig?.title && recipeConfig.title !== currentRecipeTitle) {
+      // Only reset usage if we're switching between different recipes
+      // Don't reset if we're going from no recipe to a recipe (initial load)
+      // or if we already have messages (ongoing conversation)


I think we have this comment because the code is hard to follow; let's see if we can fix that and drop the comment instead

Good call refactored and simplified

DOsinga · 2025-07-20T09:07:11Z

ui/desktop/src/components/BaseChat.tsx

  // Reset recipe usage tracking when recipe changes
  useEffect(() => {
    if (recipeConfig?.title !== currentRecipeTitle) {
+      const previousTitle = currentRecipeTitle;


suggest to move this outside the if, so the comparisons are easier to follow

DOsinga · 2025-07-20T09:13:56Z

ui/desktop/src/components/BaseChat.tsx

+      // Only reset usage if we're switching between different recipes
+      // Don't reset if we're going from no recipe to a recipe (initial load)
+      // or if we already have messages (ongoing conversation)
+      if (previousTitle && recipeConfig?.title && previousTitle !== recipeConfig.title) {


here and below, we already checked previousTitle != recipeConfig.title so that bit is always going to be true. So for this to not be true, either previousTitle or recipeConfig?title needs to be falsey. if that's the case we should check on that

Good catch, fixed

DOsinga · 2025-07-20T09:17:46Z

ui/desktop/src/components/ParameterInputModal.tsx

    parameters.forEach((param) => {
-      if (param.default) {
-        initialValues[param.key] = param.default;
+      // Set default value for optional parameters if they have a default value


I don't think we need the comment here

DOsinga · 2025-07-20T09:29:34Z

ui/desktop/src/components/ViewRecipeModal.tsx

+        if (!allParams.some((param) => param.key === promptParam.key)) {
+          allParams.push(promptParam);
+        }
+      });


this is O(n^2) - consider using a map to do this more efficiently

Good catch, fixed

DOsinga · 2025-07-20T09:29:54Z

ui/desktop/src/components/ViewRecipeModal.tsx

      const formattedParam: Parameter = {
        key: param.key,
-        input_type: 'string',
+        input_type: param.input_type || 'string', // Use actual input_type instead of hardcoded 'string'


remove the comment

DOsinga · 2025-07-20T09:31:32Z

ui/desktop/src/hooks/useRecipeManager.ts


  // Pre-fill input with recipe prompt instead of auto-sending it
  const initialPrompt = useMemo(() => {
+    // Don't show initial prompt if we already have messages (ongoing conversation)


are we calling this in the wrong place? the initial prompt shouldn't change because we have a conversation, we should just not put at as the non-initial prompt

Good catch, fixed

DOsinga · 2025-07-20T09:32:50Z

ui/desktop/src/hooks/useRecipeManager.ts

-    setRecipeParameters(inputValues);
+    // Store parameters in chat context instead of local state
+    if (chatContext?.setRecipeParameters) {
+      chatContext.setRecipeParameters(inputValues);


in what case is chatContext undefined here? can we use the type system to make sure it is not?

its a provider that we only use for certain cases at runtime so the type system isn't enough to catch it unfortunately

DOsinga · 2025-07-20T09:34:03Z

ui/desktop/src/recipe/index.ts

+    | string; // Can also be a string representation
  // Properties added for scheduled execution
  scheduledJobId?: string;
  isScheduledExecution?: boolean;


Not for now, but we have this definition also on the server. for some reason we're not using the openapi mechanism to do recipe calls, so we duplicate the definition here. do you think we can fix that?

Good call, went ahead and added it to the openai types

…ters * 'main' of github.com:block/goose: Updating docs to match new UI (#3552) Improve Claude Code provider error message for missing CLI (#3363)

zanesq · 2025-07-21T20:50:53Z

@DOsinga great review thanks! All issues addressed pls take another look.

Regarding how we can verify, unfortunately until there are more functional/ui tests covering this process its a manual testing process. I'll make sure we cover recipes in the tests as we build them out.

DOsinga · 2025-07-22T08:58:30Z

ui/desktop/src/components/pair.tsx

  messageHistoryIndex: number;
  messages: Message[];
  recipeConfig?: Recipe | null; // Add recipe configuration to chat state
+  recipeParameters?: Record<string, string> | null; // Add recipe parameters to chat state


why are hub and pair having the same diff & code here?

Good catch also, refactored to use a shared ChatType instead 👍

DOsinga · 2025-07-22T09:00:47Z

hmm, weird error. can you try merging in main?

…ters * 'main' of github.com:block/goose: Add recipe install warning (#3537) Replace mcp_core::resource::* with rmcp types (#3563) Add YouTube video embed to using-goosehints.md (#3560) fix: ensure retry-config and success-criteria are populated in openapi spec (#3575) fix: use sequential when sub recipe task is 1. (#3573) fix: track message id to keep like with like (#3572) Replace mcp_core::prompt with rmcp::model types (#3561) feat (ui): close recipe modals with esc key (#3568) feat: recipes can retry with success criteria (#3474) Env var to set Ollama request timeout (#3516)

…zane/recipe-parameters * 'zane/recipe-parameters' of github.com:block/goose: Add recipe install warning (#3537) Replace mcp_core::resource::* with rmcp types (#3563) Add YouTube video embed to using-goosehints.md (#3560) fix: ensure retry-config and success-criteria are populated in openapi spec (#3575) fix: use sequential when sub recipe task is 1. (#3573) fix: track message id to keep like with like (#3572) Replace mcp_core::prompt with rmcp::model types (#3561) feat (ui): close recipe modals with esc key (#3568) feat: recipes can retry with success criteria (#3474) Env var to set Ollama request timeout (#3516)

* 'main' of github.com:block/goose: (23 commits) fix: add fallback id to messages if none provided (#3584) feat: migrate ErrorData from internal mcp crates to rmcp version (#3586) fix: adjust subrecipe description to allow running tests (#3585) Scenario tests (#3430) feat: migrate JsonRpcMessage/Request/Response/Error/Notification from internal mcp crates to rmcp versions (#3564) Restore recipe parameters functionality (#3530) feat: Enhanced loading states with thinking icons and flying bird animation (#3478) Agent loop defensive (#3554) chore: remove needless clone() in goose/providers (#2528) Add recipe install warning (#3537) Replace mcp_core::resource::* with rmcp types (#3563) Add YouTube video embed to using-goosehints.md (#3560) fix: ensure retry-config and success-criteria are populated in openapi spec (#3575) fix: use sequential when sub recipe task is 1. (#3573) fix: track message id to keep like with like (#3572) Replace mcp_core::prompt with rmcp::model types (#3561) feat (ui): close recipe modals with esc key (#3568) feat: recipes can retry with success criteria (#3474) Env var to set Ollama request timeout (#3516) Updating docs to match new UI (#3552) ...

* main: docs: desktop recipe format (#3594) Fix model display name not being updated immediately after leaving settings (#3587) Added option to summarize the chat when an error is triggered (#3598) Remove mcp_macros and unused types (#3581) fix: add fallback id to messages if none provided (#3584) feat: migrate ErrorData from internal mcp crates to rmcp version (#3586) fix: adjust subrecipe description to allow running tests (#3585) Scenario tests (#3430) feat: migrate JsonRpcMessage/Request/Response/Error/Notification from internal mcp crates to rmcp versions (#3564) Restore recipe parameters functionality (#3530) feat: Enhanced loading states with thinking icons and flying bird animation (#3478) Agent loop defensive (#3554) chore: remove needless clone() in goose/providers (#2528) Add recipe install warning (#3537) Replace mcp_core::resource::* with rmcp types (#3563) Add YouTube video embed to using-goosehints.md (#3560) fix: ensure retry-config and success-criteria are populated in openapi spec (#3575)

* main: feat: subagent turn count, simple agent loop (#3597) feat: subagent independent extension manager (#3596) Improve session history loading resiliency (#3588) Added logging and changed default route case to not redirect to home when there is an invalid route (#3610) fix: chat sidebar layout overlapping content occasionally (#3590) fix: loading shared sessions (#3607) docs: use installer component for tutorial, add updating extensions section (#3608) fix: show token alert popover during agent responses and agent failure cases (#3536) reuse the cancellation token in the agent level (#3599) Docs: Move MongoDB tutorial to MCP section (#3602) docs: desktop recipe format (#3594) Fix model display name not being updated immediately after leaving settings (#3587) Added option to summarize the chat when an error is triggered (#3598) Remove mcp_macros and unused types (#3581) fix: add fallback id to messages if none provided (#3584) feat: migrate ErrorData from internal mcp crates to rmcp version (#3586) fix: adjust subrecipe description to allow running tests (#3585) Scenario tests (#3430) feat: migrate JsonRpcMessage/Request/Response/Error/Notification from internal mcp crates to rmcp versions (#3564) Restore recipe parameters functionality (#3530)

Signed-off-by: Adam Tarantino <[email protected]>

zanesq added 4 commits July 19, 2025 13:47

added back recipe parameter support

66ae443

fix chat submitting text when unrelated button elements are clicked

8e145d3

fix navigating away from active recipe resets recipe in progress

97732f3

revert button changes

135ad72

zanesq commented Jul 20, 2025

View reviewed changes

zanesq added 4 commits July 19, 2025 18:48

actually use select, boolean and number fields

e7f8b58

update recipe preview to show all possible recipe values

7bba69d

added recipe deeplink to preview

17db8ee

change display to one line for deeplink

4e1988c

DOsinga self-requested a review July 20, 2025 08:54

DOsinga approved these changes Jul 20, 2025

View reviewed changes

zanesq added 12 commits July 21, 2025 11:38

merge in main and add missing recipe types

520f448

change deeplink in recipe preview to use new server version

4644484

move previousTitle outside of conditional

4863743

refactor hasRecipeChanged logic to be more readable

4e8363c

remove redundant check for previousTitle

353baf3

simplify complex validation logic

66dc3a5

remove comment

67ebebc

preserve existing params and add new ones

91291e2

change lookups to be more efficient with maps and set

73017ae

remove comment

1dbb5fd

change initialPrompt to return the actual recipe prompt when available

893c2a0

Merge branch 'main' of github.com:block/goose into zane/recipe-parame…

0d603a0

…ters * 'main' of github.com:block/goose: Updating docs to match new UI (#3552) Improve Claude Code provider error message for missing CLI (#3363)

zanesq requested a review from DOsinga July 21, 2025 20:50

DOsinga reviewed Jul 22, 2025

View reviewed changes

zanesq added 3 commits July 22, 2025 08:47

refactor to shared ChatType

8b4fd1d

zanesq merged commit 246ba19 into main Jul 22, 2025
7 of 8 checks passed

zanesq deleted the zane/recipe-parameters branch July 22, 2025 17:31

zanesq added a commit that referenced this pull request Jul 23, 2025

Restore recipe parameters functionality (#3530)

505e9b9

zanesq restored the zane/recipe-parameters branch July 23, 2025 23:33

atarantino pushed a commit to atarantino/goose that referenced this pull request Aug 5, 2025

Restore recipe parameters functionality (block#3530)

59b3df7

Signed-off-by: Adam Tarantino <[email protected]>

Conversation

zanesq commented Jul 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DOsinga left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zanesq commented Jul 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DOsinga commented Jul 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zanesq commented Jul 20, 2025 •

edited

Loading